Discussion:
Independence of the new lib.system module.
Edward d'Auvergne
2016-04-20 09:41:09 UTC
Permalink
Hi Troels,

In running the test suite, I noticed the following test failing:

$ ./relax --verification-tests Library.test_library_independence

The problem is the lib.system module, in that you cannot import the
status module. Instead you should call
status.observers.system_cwd_path.notify() after any calls to
lib.system.cd(), i.e. outside of the relax library, rather than in
this function itself.

Cheers,

Edward

_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
relax-***@gna.org

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page
Edward d'Auvergne
2016-05-12 07:21:14 UTC
Permalink
Post by Edward d'Auvergne
Hi Troels,
$ ./relax --verification-tests Library.test_library_independence
The problem is the lib.system module, in that you cannot import the
status module. Instead you should call
status.observers.system_cwd_path.notify() after any calls to
lib.system.cd(), i.e. outside of the relax library, rather than in
this function itself.
Hi Troels,

In preparation for a new relax release, I'll fix this issue myself. I
am simply shifting lib.system to pipe_control.system. The
pipe_control package is mainly for processing arguments, providing
feedback, calling other code to do the work, and updating the relax
state. But as the system.cd and system.pwd user functions are almost
entirely composed of argument processing, feedback, and updating the
state, I think that it can just all go there. I'll also update the
copyright notices with your new name :)

Regards,

Edward

_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
relax-***@gna.org

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
htt
Troels Emtekær Linnet
2016-05-12 10:41:45 UTC
Permalink
Thank you!

Best
Troels
Post by Edward d'Auvergne
Post by Edward d'Auvergne
Hi Troels,
$ ./relax --verification-tests Library.test_library_independence
The problem is the lib.system module, in that you cannot import the
status module. Instead you should call
status.observers.system_cwd_path.notify() after any calls to
lib.system.cd(), i.e. outside of the relax library, rather than in
this function itself.
Hi Troels,
In preparation for a new relax release, I'll fix this issue myself. I
am simply shifting lib.system to pipe_control.system. The
pipe_control package is mainly for processing arguments, providing
feedback, calling other code to do the work, and updating the relax
state. But as the system.cd and system.pwd user functions are almost
entirely composed of argument processing, feedback, and updating the
state, I think that it can just all go there. I'll also update the
copyright notices with your new name :)
Regards,
Edward
_______________________________________________
relax (http://www.nmr-relax.com)
This is the relax-devel mailing list
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
relax-***@gna.org

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel

Loading...